Avoid returning 500 for TRACE_TOO_LARGE #4160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zalegrala
force-pushed
the
frontendTraceTooLargeErr
branch
from
a62bf71 to
7d60b99
Compare
zalegrala
requested review from
joe-elliott,
annanay25,
mdisibio,
mapno,
yvrhdn,
electron0zero,
ie-pham,
stoewer and
javiermolinar
as code owners
joe-elliott
reviewed
Oct 16, 2024
zalegrala
force-pushed
the
frontendTraceTooLargeErr
branch
from
671627d to
0b86b08
Compare
joe-elliott
reviewed
Oct 17, 2024
zalegrala
changed the title
zalegrala
force-pushed
the
frontendTraceTooLargeErr
branch
from
76f7059 to
94a6eea
Compare
joe-elliott
approved these changes
Oct 17, 2024
|
nice one 👍 |
Co-authored-by: Javier Molina Reyes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Here we make an adjustment to the return value at the querier and query-frontend for the case where a trace is larger than the max configured size. Previously this was reported as a 500 status code and has now been changed to a 422. This will allow these conditions to be excluded from SLO failures, which is more appropriate since this is based on a configured max trace size.
Which issue(s) this PR fixes:
Fixes #
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]