fix: counter samples being downsampled when series is new #4236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javiermolinar
requested review from
joe-elliott,
mdisibio,
mapno,
yvrhdn,
zalegrala,
electron0zero,
ie-pham and
stoewer
as code owners
javiermolinar
changed the title
javiermolinar
changed the title
mapno
approved these changes
Oct 25, 2024
yvrhdn
approved these changes
Oct 25, 2024
knylander-grafana
pushed a commit
that referenced
this pull request
Oct 29, 2024
It fixes an issue with adaptive metrics: when a series is new the init sample ends in the same aggregation bucket as the span one, and the later one is downsampled. The fix consists of backdating the initial one to the end of the previous minute
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
It fixes an issue with adaptive metrics: when a series is new the init sample ends in the same aggregation bucket as the span one, and the later one is downsampled. The fix consists of backdating the initial one to the end of the previous minute:
previously:
(t-1ms, 0)
(t, 1)
current:
(t-1m, 0)
(t, 1)
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]