Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade OTel to reduce allocs #4243

Merged
merged 4 commits into from
Oct 29, 2024
Merged

Conversation

joe-elliott
Copy link
Member

What this PR does:
Upgrade OTel SDK to reduce allocs. During times of intense querying we see a large number of allocs in sync.DoOnce buried in the go otel instrumentation. This was improved here: open-telemetry/opentelemetry-go#5858

Full release notes: https://github.com/open-telemetry/opentelemetry-go/releases/tag/v1.31.0

Checklist

  • Tests updated
  • Documentation added
  • CHANGELOG.md updated - the order of entries should be [CHANGE], [FEATURE], [ENHANCEMENT], [BUGFIX]

Signed-off-by: Joe Elliott <[email protected]>
Signed-off-by: Joe Elliott <[email protected]>
Copy link
Contributor

@javiermolinar javiermolinar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@joe-elliott joe-elliott merged commit 5fd1792 into grafana:main Oct 29, 2024
16 checks passed
knylander-grafana pushed a commit that referenced this pull request Oct 29, 2024
* Upgrade OTel to reduce allocs

Signed-off-by: Joe Elliott <[email protected]>

* changelog + vendor

Signed-off-by: Joe Elliott <[email protected]>

* update mod

Signed-off-by: Joe Elliott <[email protected]>

* actually catch the desired change

Signed-off-by: Joe Elliott <[email protected]>

---------

Signed-off-by: Joe Elliott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants