Add search block headers #943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Martin Disibio <[email protected]>
mdisibio
requested review from
annanay25,
dgzlopes,
joe-elliott,
yvrhdn and
mapno
as code owners
12 tasks
Signed-off-by: Martin Disibio <[email protected]>
Signed-off-by: Martin Disibio <[email protected]>
Signed-off-by: Martin Disibio <[email protected]>
Signed-off-by: Martin Disibio <[email protected]>
annanay25
reviewed
Sep 14, 2021
12 tasks
Signed-off-by: Martin Disibio <[email protected]>
Signed-off-by: Martin Disibio <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds block-level search data which speeds up some searches by eliminating blocks faster. The block header contains the superset of unique tags and duration range within the block. Data is stored in a new file
search-headerwith a dedicated flatbuffer struct.x=y. This is no longer possible since it eliminates the block immediately due to tag not present in the header. Since we still want these abilities it was readded with a secret tagx-dbg-exhaustive. If this tag is present in the search then it will evaluate all data again.This is likely to conflict with #940 so let's merge that first.Which issue(s) this PR fixes:
Fixes part of #932
Checklist
CHANGELOG.mdupdated - the order of entries should be[CHANGE],[FEATURE],[ENHANCEMENT],[BUGFIX]