add grafana_oncall_user_notification_rule resource
#1653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In order to lower resource usage and have a faster runtime, PRs will not run Cloud tests automatically. |
|
This is going to be an annoying comment but we're trying to get rid of the old TF framework (which is what this PR is using). New resources look like this: https://github.com/grafana/terraform-provider-grafana/blob/main/internal/resources/cloud/resource_cloud_org_member.go |
|
thanks for pointing that out @julienduchesne, will take a look 👍 |
3 tasks
…of github.com:grafana/terraform-provider-grafana into jorlando/add-oncall-user-notification-policy-resource
joeyorlando
added a commit
to grafana/oncall
that referenced
this pull request
Jul 5, 2024
# What this PR does Related to #4410 The changes in this PR are a prerequisite to grafana/terraform-provider-grafana#1653. See the conversation [here](https://raintank-corp.slack.com/archives/C04JCU51NF8/p1719806995902499?thread_ts=1719520920.744319&cid=C04JCU51NF8) for more context on why we decided to move away from always creating default personal notification rules for users. ## Checklist - [x] Unit, integration, and e2e (if applicable) tests updated - [x] Documentation added (or `pr:no public docs` PR label added if not required) - [x] Added the relevant release notes label (see labels prefixed w/ `release:`). These labels dictate how your PR will show up in the autogenerated release notes.
internal/resources/oncall/resource_user_notification_rule_test.go
Outdated
Show resolved
Hide resolved
vstpme
reviewed
Jul 8, 2024
| var ( | ||
| resourceUserNotificationRuleName = "grafana_oncall_user_notification_rule" | ||
|
|
||
| userNotificationRuleTypeOptions = []string{ |
There was a problem hiding this comment.
Addressed in bdc35ec (I'll also update our public API docs to make a mention that this is available as well (only in Grafana Cloud))
There was a problem hiding this comment.
…of github.com:grafana/terraform-provider-grafana into jorlando/add-oncall-user-notification-policy-resource
julienduchesne
deleted the
jorlando/add-oncall-user-notification-policy-resource
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to the Terraform portion of grafana/oncall#4410
Closes grafana/oncall#1193
Once a new provider version is released, I will open a PR in https://github.com/grafana/crossplane-provider-grafana to generate the related Crossplane resources
Tested on my local stack all of the following cases and all work as expected:
grafana_oncall_user_notification_rule, varioustypes andpositionsuser_idorimportantvalue for a resource, should delete the old resource and create a new one