Turn Browser.UserAgent to return err

browser/browser_mapping.go

@@ -56,7 +56,7 @@ func mapBrowser(vu moduleVU) mapping { //nolint:funlen,cyclop
 			if err != nil {
 				return "", err
 			}
-			return b.UserAgent(), nil
+			return b.UserAgent() //nolint:wrapcheck
 		},
 		"version": func() (string, error) {
 			b, err := vu.browser()

browser/mapping_test.go

@@ -255,7 +255,7 @@ type browserAPI interface {
 	NewContext(opts goja.Value) (*common.BrowserContext, error)
 	NewPage(opts goja.Value) (*common.Page, error)
 	On(string) (bool, error)
-	UserAgent() string
+	UserAgent() (string, error)
 	Version() string
 }
 

common/browser.go

@@ -628,13 +628,13 @@ func (b *Browser) On(event string) (bool, error) {
 }
 
 // UserAgent returns the controlled browser's user agent string.
-func (b *Browser) UserAgent() string {
+func (b *Browser) UserAgent() (string, error) {
 	action := cdpbrowser.GetVersion()
-	_, _, _, ua, _, err := action.Do(cdp.WithExecutor(b.ctx, b.conn))
+	_, _, _, ua, _, err := action.Do(cdp.WithExecutor(b.ctx, b.conn)) //nolint:dogsled
 	if err != nil {
-		k6ext.Panic(b.ctx, "getting browser user agent: %w", err)
+		return "", fmt.Errorf("getting browser user agent: %w", err)
 	}
-	return ua
+	return ua, nil
 }
 
 // Version returns the controlled browser's version.

tests/browser_test.go

@@ -210,7 +210,8 @@ func TestBrowserUserAgent(t *testing.T) {
 
 	// testBrowserVersion() tests the version already
 	// just look for "Headless" in UserAgent
-	ua := b.UserAgent()
+	ua, err := b.UserAgent()
+	require.NoError(t, err)
 	if prefix := "Mozilla/5.0"; !strings.HasPrefix(ua, prefix) {
 		t.Errorf("UserAgent should start with %q, but got: %q", prefix, ua)
 	}