Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Fix Async examples #1368

Merged
merged 4 commits into from
Jun 4, 2024
Merged

Fix Async examples #1368

merged 4 commits into from
Jun 4, 2024

Conversation

inancgumus
Copy link
Member

@inancgumus inancgumus commented Jun 4, 2024

What?

Fixes await usage.

Why?

The examples were incorrectly using await, leading to incorrect results.

Checklist

  • I have performed a self-review of my code
  • I have added tests for my changes
  • I have commented on my code, particularly in hard-to-understand areas

Related PR(s)/Issue(s)

Sorry, something went wrong.

@inancgumus inancgumus added bug Something isn't working documentation Improvements or additions to documentation async supports async (promises) labels Jun 4, 2024
@inancgumus inancgumus self-assigned this Jun 4, 2024
@inancgumus inancgumus requested review from ankur22 and allansson June 4, 2024 14:18
@inancgumus inancgumus marked this pull request as ready for review June 4, 2024 14:19
Copy link
Collaborator

@ankur22 ankur22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@inancgumus inancgumus merged commit b5b45e4 into main-async Jun 4, 2024
14 checks passed
@inancgumus inancgumus deleted the fix/async/examples branch June 4, 2024 14:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
async supports async (promises) bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants