Skip to content
This repository has been archived by the owner on Jan 30, 2025. It is now read-only.

Update to k6 v0.38.0, fix breaking changes #302

Merged
merged 3 commits into from
May 6, 2022
Merged

Conversation

imiric
Copy link
Contributor

@imiric imiric commented May 5, 2022

This updates the k6 dependency to v0.38.0 and fixes the breaking changes of the stats -> metrics package move (grafana/k6#2433), and the move of the stats.New function to registry.NewMetric method (grafana/k6#2442).

The latter was done by attaching a custom struct to our internal context, but we might not need this globally on the context, so I'm open to improvement suggestions.

Ivan Mirić added 3 commits May 5, 2022 17:30
This is a fix for a breaking change introduced in k6 v0.38.0[1].

[1]: grafana/k6#2433
This is a fix for a breaking change introduced in k6 v0.38.0[1].

[1]: grafana/k6#2442
@imiric imiric requested review from inancgumus and ankur22 May 5, 2022 15:55
@imiric imiric added this to the v0.3.0 milestone May 5, 2022
Copy link
Member

@inancgumus inancgumus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@imiric imiric merged commit d65182e into main May 6, 2022
@imiric imiric deleted the update/k6-v0.38.0 branch May 6, 2022 14:00
@inancgumus inancgumus added the dependencies Pull requests that update a dependency file label Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants