Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parser #13

Merged
merged 4 commits into from
Jun 18, 2018
Merged

Parser #13

merged 4 commits into from
Jun 18, 2018

Conversation

grafuls
Copy link
Owner

@grafuls grafuls commented Jun 15, 2018

No description provided.

@grafuls grafuls added this to the POC milestone Jun 16, 2018
@grafuls
Copy link
Owner Author

grafuls commented Jun 16, 2018

#8

Copy link
Collaborator

@ILpinto ILpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

type is saved word, may change to action_type

"""
A trigger object with the requested disruptive action.
"""
type = attr.ib(validator=attr.validators.instance_of(six.text_type))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

action_type

doc = None
try:
with open(self.yaml_path, 'r') as f:
import ipdb;ipdb.set_trace()
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

Copy link
Collaborator

@ILpinto ILpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the last version after testing ?

return _actions

doc = None
try:
with open(self.yaml_path, 'r') as f:
import ipdb;ipdb.set_trace()
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

??

grafuls added 2 commits June 18, 2018 16:31
Change-Id: I0bc57042a0e6fb93ad66852de7c4a186d95fcc94
Change-Id: I21f50f5576d207e4e6bf7894928e76d9e4b118ef
@grafuls grafuls merged commit 96f893b into master Jun 18, 2018
@grafuls grafuls deleted the parser branch June 18, 2018 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants