Removed automatic Crumb Trail truncation #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No truncation is the better default. Repeated state truncation was necessary when back navigation relied on it. But back navigation truncation doesn’t use truncateCrumbTrail anymore. Also, with react native navigation, the crumb trail is more relevant. Don’t want to override truncateCrumbTrail on every state just to remove the repeated State truncation rule.
These tests now match the default truncateCrumbTrail implementation. Need new tests for custom truncation
Custom Trail tests now the same as With Trail tests
This reverts commit b1ca12b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally, if the Crumb Trail didn’t truncate at repeated States then back navigation increased, rather than decreased, the Crumb Trail. But back navigation no longer relies on Crumb Trail truncation, so it’s safe to remove.
If it wasn’t removed then, with the introduction of Navigation React Native, all States would need a custom truncateCrumbTrail function that removes it.