Added Scene Context Parameters to Motion Style props #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Already variable called nextCrumb
The crumb fades out and the photo fades in, instead of sliding back and in
If the photo's from a reply then do want to share it, but if it's from the selected tweet then don't. The unmounted style is the slide in, so checked the previous state and data to see if the photo scene has come from the tweet with the same id
Don't want to zoom if photo goes from timeline to replies. Set an enable item in shared element data, set it to false in tweets (timeline and replies) and true in photo, and filtered out shared elements without enable true
If photo bookmarked then X should go back to tweet that owns the photo and then to home
Unmounted style only called when there's at least one crumb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
crumbsparameter to the three stylepropsof theNavigationMotioncomponent andnextStateandnextDatato thecrumbStyle prop. Allows animations to vary based on the context. Enhanced the Twitter sample with photo zoom to demonstrate. Tweet slides in but Photo fades in.