Represented Blank Url-Encoded Parameters by only their Key in the Query String #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't want to pass null (or undefined) to decode because decodeURIComponent(null) is 'null'. If someone forgot to put a matching decode for the blank encode then would end up with a value of 'null' and confusion. With '' you'd realise you hadn't decoded the blank. Plus a query stirng of ?a is handled the same as ?a= Can't generate the second one but it could be passed in
Routes params can't accept blank encoded values. There's no way to tell if the value is blank because it's encoded as blank or just not provided. In the first case want to call decode but not in the second
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can turn url of
a?x=trueintoa?xby returning''fromurlEncodefor parameter keyx