Removed react-dom dependency from Navigation React #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commented out the tests because they'll come back when react suspense lands. Hard-coded defer to false but left in some unreachable defer code as a reminder
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Navigation React Native depends on Navigation React but shouldn't need
react-dom.It was only there to test out deferred updates. When React Suspense lands, deferred updates will come back but then they should be part of the React API so still won't need the
react-domdependency. Commented out the deferred tests because they'll be coming back with Suspense. Left some deferred code inAsyncStateNavigatoras a reminder.