Allowed Customised Animation on Android #210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Has to run on the ui thread otherwise it gets ignored (or is sometimes ignored, not sure which?)
If null returned default. The lookup returns 0 if name not found so that's no animation, which seems fair
Imagine going from State A to State C fluently so that State B is in the middle. The exit State is A and the enter State is C, but A's next State is B. Similarly going back 2 from C to A, the exit State is C and enter is A, but A's next State is B. This is different to Navigation React Mobile because render all Scenes in succession so next State is automatic. In Native, need to use the old crumbs, state and data to get the right next State and next data.
Makes animation read better detail.getUnmountStyle = from => from ? 'slide_in' : 'slide_out';
Allows addNavigateHandlers to be called before initial navigate
Even thought they're not used, keeps the NavigationModule render params in step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Used native
overridePendingTransitionbecause allows the enter and the exit animation to be customised. The exit can either be unmounting or becoming a crumb; the enter can either be mounting from unmounted or from crumb. So there’s four different animations that can be overridden. Had to run the override on the ui thread. Had to get the default andorid animations so that can only override enter, for example, but leave exit as the default.Made the
getCrumbStyleandgetUnmountedStylematch the params of the corresponding functions on Navigation React Mobile. Had to parse the old url to get theCrumbs, unlike on Mobile because, because need to callgetCrumbStylewhen remounting.