Supported React Native v0.60 #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hand wrote rather than use the package.json driven approach of https://github.com/react-native-community/react-native-webview/blob/master/react-native-webview.podspec
These changes are in response to errors from Refactor --> Migrate to AndroidX
Ran Refactor --> Migrate to AndroidX and this was all that changed
These were added to migrate to AndroidX and aren't needed now migration complete
Removing this unused attribute means the package is backward compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only essential change was adding a
podspec. Without it can’t runpod installand iOS won’t work.Technically, didn’t need any android changes at all. But the automated 'Migrate to AndroidX' built into Android studio wouldn't run without gradle settings changes (updating version numbers). The migration only changed the
AndroidJUnitRunnernamespace. Given it's only used for unit testing, deleted it instead of keeping the change.Updated medley sample to React Native 0.60 to test the package changes