Ensured openDrawer of DrawerLayoutAndroid works on all screens #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there's a Drawer then it the layout needs to happen after it's attached to the window
grahammendick
added a commit
that referenced
this pull request
Sep 8, 2021
Applied the fix from over 2 years ago to the SceneView again and it works, #266! Not sure why it didn't work for Fragments back then but it does now, #264 (comment)?
This was referenced Sep 8, 2021
grahammendick
added a commit
that referenced
this pull request
Jul 16, 2024
I checked back and this seemed to be for handling activities - apparently drawer didn't open on second activity (#266). This seems to be a good time to remove this old code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #264
Calling
openDraweronly worked on the first screen, but not any subsequent ones.The
DrawerLayouton Android expects the layout to be done after it’s attached to the window. If it’s done before then it doesn’t open.When navigating to a second screen React Native renders and does the layout first and then I start a new Activity and set the content. That’s the wrong order for the
DrawerLayout. I fixed this by doing a second layout pass for the DrawerLayout after it’s attached to the window. I got the idea from theViewPagercomponent.To avoid importing an androidx namespace I checked for DrawerLayout using a string. This means it works in both React Native 0.59 and 0.60. Unfortunately couldn’t check for
ReactDrawerLayoutbecause it’s not public.