Code

Supported Sheet Component#787

Code

Merged

grahammendick merged 90 commits intomastergrahammendick/navigation:masterfrom dialog-backgrahammendick/navigation:dialog-backCopy head branch name to clipboardJun 30, 2024

+2,128-654

Commits

Commits on Jun 14, 2024

• Added in the basic files for Dialog on old arch

  grahammendick

  committed
  467f826

  Copy full SHA for 467f826

Commits on Jun 15, 2024

• Sketched in dialog fragment and root view

  Show description for c141b78
  grahammendick

  committed
  c141b78

  Copy full SHA for c141b78

• Renamed stack context to fragment context

  Show description for 07f668b
  grahammendick

  committed
  07f668b

  Copy full SHA for 07f668b

• Added views to dialog and opened dialog on show

  Show description for 41c115a
  grahammendick

  committed
  41c115a

  Copy full SHA for 41c115a

• Resized dialog to take up all the room

  Show description for 228a075
  grahammendick

  committed
  228a075

  Copy full SHA for 228a075

• Used showNow instead of custom code

  Show description for 9623e53
  grahammendick

  committed
  9623e53

  Copy full SHA for 9623e53

• Removed redundant import

  grahammendick

  committed
  f612286

  Copy full SHA for f612286

• Ran a stack inside modal (in twitter sample)

  Show description for 4b43b99
  grahammendick

  committed
  4b43b99

  Copy full SHA for 4b43b99

• Allowed transparent modal

  Show description for c8c9e67
  grahammendick

  committed
  c8c9e67

  Copy full SHA for c8c9e67

Commits on Jun 16, 2024

• Got predictive back working on dialog stack!!

  Show description for 8ef52cc
  grahammendick

  committed
  8ef52cc

  Copy full SHA for 8ef52cc

• Removed android studio warning

  Show description for 7882431
  grahammendick

  committed
  7882431

  Copy full SHA for 7882431

• Added new line for consistency

  grahammendick

  committed
  aa91e3e

  Copy full SHA for aa91e3e

Commits on Jun 17, 2024

• Merge branch 'master' into dialog-back

  grahammendick

  committed
  ac0cfd8

  Copy full SHA for ac0cfd8

Commits on Jun 18, 2024

• Dispatched over fragment controller events

  Show description for 5d38168
  grahammendick

  committed
  5d38168

  Copy full SHA for 5d38168

• Added the dialog fragment to the root frag manager

  Show description for 603edaf
  grahammendick

  committed
  603edaf

  Copy full SHA for 603edaf

• Reversed the if for clarity

  Show description for 9118be1
  grahammendick

  committed
  9118be1

  Copy full SHA for 9118be1

• Removed redundant import

  grahammendick

  committed
  a0b5a09

  Copy full SHA for a0b5a09

Commits on Jun 19, 2024

• Ensured dialog can be reopened

  Show description for e063dcb
  grahammendick

  committed
  e063dcb

  Copy full SHA for e063dcb

• Removed redundant dismissed field

  Show description for a5d79f4
  grahammendick

  committed
  a5d79f4

  Copy full SHA for a5d79f4

• Removed redundant event count

  Show description for 08c0ff7
  grahammendick

  committed
  08c0ff7

  Copy full SHA for 08c0ff7

• Removed redundant import

  grahammendick

  committed
  38d2a7d

  Copy full SHA for 38d2a7d

• Ensured dialog dismissed when detached

  Show description for aad190f
  grahammendick

  committed
  aad190f

  Copy full SHA for aad190f

Commits on Jun 21, 2024

• Created a non-modal dialog - a sheet

  Show description for da6bb8c
  grahammendick

  committed
  da6bb8c

  Copy full SHA for da6bb8c

• Ensured modal dialog works with same stack context

  Show description for b59e8ab
  grahammendick

  committed
  b59e8ab

  Copy full SHA for b59e8ab

• Added dialog root view from js for clarity

  Show description for e385696
  grahammendick

  committed
  e385696

  Copy full SHA for e385696

• Removed redundant code

  Show description for de886e6
  grahammendick

  committed
  de886e6

  Copy full SHA for de886e6

• Ensured root view there before showing

  Show description for 923c344
  grahammendick

  committed
  923c344

  Copy full SHA for 923c344

• Showed dialog root only for modal

  Show description for cac3a88
  grahammendick

  committed
  cac3a88

  Copy full SHA for cac3a88

• Showed sheet or dialog depending on modal prop

  grahammendick

  committed
  ab70eef

  Copy full SHA for ab70eef

• Prevented error toggling modal from true to false

  Show description for 613f1ec
  grahammendick

  committed
  613f1ec

  Copy full SHA for 613f1ec

• Added sheet earlier than attached

  Show description for 2dce6b9
  grahammendick

  committed
  2dce6b9

  Copy full SHA for 2dce6b9

• Ensured can navigate in stack behind non-modal

  Show description for cedeaf4
  grahammendick

  committed
  cedeaf4

  Copy full SHA for cedeaf4

• Ensured gesture back works with multiple modals

  Show description for 140e7be
  grahammendick

  committed
  140e7be

  Copy full SHA for 140e7be

Commits on Jun 22, 2024

• Moved FragmentHostCallback into DialogRootView

  Show description for 28edd70
  grahammendick

  committed
  28edd70

  Copy full SHA for 28edd70

• Brought across detent/dismissed from BottomSheet

  Show description for 1664c07
  grahammendick

  committed
  1664c07

  Copy full SHA for 1664c07

• Forgot to commit this with recent changes

  grahammendick

  committed
  d711553

  Copy full SHA for d711553

• Added detent stuff to sheet view

  grahammendick

  committed
  f6ebd90

  Copy full SHA for f6ebd90

• Removed redundant import

  grahammendick

  committed
  88b9f06

  Copy full SHA for 88b9f06

• Allowed dynamically toggling modal

  Show description for a62b824
  grahammendick

  committed
  a62b824

  Copy full SHA for a62b824

• Started to move changes to bottom sheet

  Show description for a3cf5e3
  grahammendick

  committed
  a3cf5e3

  Copy full SHA for a3cf5e3

• Got the expanded offset and height back

  Show description for f72319f
  grahammendick

  committed
  f72319f

  Copy full SHA for f72319f

• Added missing newline

  grahammendick

  committed
  9f74924

  Copy full SHA for 9f74924

• Added missing newline

  grahammendick

  committed
  3460b5c

  Copy full SHA for 3460b5c

Commits on Jun 23, 2024

• Added root view from native to match bottomsheet

  Show description for 01eec1d
  grahammendick

  committed
  01eec1d

  Copy full SHA for 01eec1d

• Removed redundant code

  Show description for 7c51495
  grahammendick

  committed
  7c51495

  Copy full SHA for 7c51495

• Implemented stack for non-modal bottom sheet

  Show description for 159750f
  grahammendick

  committed
  159750f

  Copy full SHA for 159750f

• Removed redundant spaces

  grahammendick

  committed
  605a781

  Copy full SHA for 605a781

• Combined bottomsheet and dialog into sheet comp

  Show description for 745a8e0
  grahammendick

  committed
  745a8e0

  Copy full SHA for 745a8e0

• Allowed stack to get frag manager for dialogs

  Show description for 54e45a0
  grahammendick

  committed
  54e45a0

  Copy full SHA for 54e45a0

• Removed unreachable code

  Show description for 762202a
  grahammendick

  committed
  762202a

  Copy full SHA for 762202a

• Allowed dynamically toggling bottom

  Show description for b73d695
  grahammendick

  committed
  b73d695

  Copy full SHA for b73d695

• Deleted redundant Dialog

  Show description for c48b742
  grahammendick

  committed
  c48b742

  Copy full SHA for c48b742

• Removed for consistency

  grahammendick

  committed
  0f0bf4f

  Copy full SHA for 0f0bf4f

• Renamed for consistency

  Show description for 4608a97
  grahammendick

  committed
  4608a97

  Copy full SHA for 4608a97

Commits on Jun 24, 2024

• Defaulted sheet to bottom modal

  Show description for 873059b
  grahammendick

  committed
  873059b

  Copy full SHA for 873059b

• Deleted redundant file

  Show description for bf4ac2e
  grahammendick

  committed
  bf4ac2e

  Copy full SHA for bf4ac2e

• Added check for safety

  Show description for a75743d
  grahammendick

  committed
  a75743d

  Copy full SHA for a75743d

• Tweaked format for consistency

  grahammendick

  committed
  60b70c8

  Copy full SHA for 60b70c8

• Handled fragment controller lifecycle

  Show description for 31c4305
  grahammendick

  committed
  31c4305

  Copy full SHA for 31c4305

• Removed fragment when sheet view dropped

  Show description for 09cfc81
  grahammendick

  committed
  09cfc81

  Copy full SHA for 09cfc81

• Allowed opening modals from modals (with stacks)

  Show description for 9c746b1
  grahammendick

  committed
  9c746b1

  Copy full SHA for 9c746b1

• Allowed opening non-modals from modals (& stacks)

  Show description for 8774eef
  grahammendick

  committed
  8774eef

  Copy full SHA for 8774eef

Commits on Jun 25, 2024

• Prevented coordinator intercepting sheet scrolls

  Show description for 382f7cb
  grahammendick

  committed
  382f7cb

  Copy full SHA for 382f7cb

• Removed deprecations

  grahammendick

  committed
  2f8f1c2

  Copy full SHA for 2f8f1c2

• Allowed sheet to be created expanded

  Show description for a53f0b9
  grahammendick

  committed
  a53f0b9

  Copy full SHA for a53f0b9

• Enabled predictive back on non-modal bottom sheet

  Show description for a3a8319
  grahammendick

  committed
  a3a8319

  Copy full SHA for a3a8319

• Ensured app can survive reload

  Show description for e0480ff
  grahammendick

  committed
  e0480ff

  Copy full SHA for e0480ff

Commits on Jun 26, 2024

• Removed gap before stack inside sheet is shown

  Show description for f6f99aa
  grahammendick

  committed
  f6f99aa

  Copy full SHA for f6f99aa

• Work for nested stacks inside nested modals

  Show description for 91be3aa
  grahammendick

  committed
  91be3aa

  Copy full SHA for 91be3aa

• Dismissed sheets only if root sheet

  Show description for f75afc2
  grahammendick

  committed
  f75afc2

  Copy full SHA for f75afc2

Commits on Jun 27, 2024

• Presented bottom sheet when ios < 15

  Show description for e9cc9de
  grahammendick

  committed
  e9cc9de

  Copy full SHA for e9cc9de

• Renamed for clarity

  Show description for 46e4870
  grahammendick

  committed
  46e4870

  Copy full SHA for 46e4870

• Displayed overfullscreen if not bottom

  Show description for 8006baf
  grahammendick

  committed
  8006baf

  Copy full SHA for 8006baf

• Started fabric sheet implementation

  Show description for 4093814
  grahammendick

  committed
  4093814

  Copy full SHA for 4093814

• Implemented new props and resize on fabric

  grahammendick

  committed
  8429d94

  Copy full SHA for 8429d94

• Implemented non-modal non-bottom sheet on fabric

  Show description for 232e205
  grahammendick

  committed
  232e205

  Copy full SHA for 232e205

• Implemented modal non-bottom sheet on fabric

  Show description for 468791d
  grahammendick

  committed
  468791d

  Copy full SHA for 468791d

• Removed warnings, following Android Studio advice

  grahammendick

  committed
  40dfd85

  Copy full SHA for 40dfd85

• Ensured the right tab is shown

  Show description for 8d74dc1
  grahammendick

  committed
  8d74dc1

  Copy full SHA for 8d74dc1

• Added the dummy component files for ios compile

  Show description for cfff4f2
  grahammendick

  committed
  cfff4f2

  Copy full SHA for cfff4f2

• Removed sheet stack load delay

  Show description for 65937dc
  grahammendick

  committed
  65937dc

  Copy full SHA for 65937dc

• Copied over changes from old arch

  Show description for 4be1515
  grahammendick

  committed
  4be1515

  Copy full SHA for 4be1515

Commits on Jun 28, 2024

• Prevented blank screen oddness when flinging sheet

  Show description for 74eac6a
  grahammendick

  committed
  74eac6a

  Copy full SHA for 74eac6a

• Reverted accidental changes

  grahammendick

  committed
  65f8331

  Copy full SHA for 65f8331

• Presented bottom sheet when ios < 15

  Show description for da38eba
  grahammendick

  committed
  da38eba

  Copy full SHA for da38eba

• Implemented ios props on android for fabric

  Show description for 8a238e8
  grahammendick

  committed
  8a238e8

  Copy full SHA for 8a238e8

• Reverted because not sure it made a difference

  Show description for 7f24482
  grahammendick

  committed
  7f24482

  Copy full SHA for 7f24482

• Corrected translate Y % to use height not width

  grahammendick

  committed
  d8e0cb4

  Copy full SHA for d8e0cb4

• Typed the new sheet component

  Show description for 34ace9f
  grahammendick

  committed
  34ace9f

  Copy full SHA for 34ace9f

• Renamed stackId to fragmentTag for clarity

  Show description for b5506fa
  grahammendick

  committed
  b5506fa

  Copy full SHA for b5506fa