Tidied Up Url Handling #82

grahammendick · 2016-09-12T12:45:51Z

Changed History Managers so that the only function that builds Urls is getUrl. Makes it easier to override, e.g., add generic language route parameter for internationalization
Accepted empty string as start Url. Protects against server side Url being empty
Allowed applicationPath to omit leading slash and ensured HTML5 Urls always have leading slash

Now only have to change getHref and getUrl to implement custom Url, .e.g., hashbang Url or Url with language like /en/...

Possbile that, on the server, the req.url could be empty string (although only ever seen '/')

Could happen that url doesn't begin with '/' (manually call start/navigationLink with url without slash). So, prepended slash. Don't need to do the same for HashHistory because it doesn't make up the url. Also prepended applicationPath with / if missing to make the api easier to use

grahammendick added 4 commits September 12, 2016 08:30

Called getUrl from getCurrentUrl

b9cfda9

Now only have to change getHref and getUrl to implement custom Url, .e.g., hashbang Url or Url with language like /en/...

Accepted empty string as start url

24716ce

Possbile that, on the server, the req.url could be empty string (although only ever seen '/')

Wrapped in brackets for clarity

f18ab71

grahammendick merged commit 1d4e4a7 into master Sep 12, 2016

grahammendick deleted the starturl branch September 12, 2016 12:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tidied Up Url Handling #82

Tidied Up Url Handling #82

grahammendick commented Sep 12, 2016

Tidied Up Url Handling #82

Tidied Up Url Handling #82

Conversation

grahammendick commented Sep 12, 2016