Supported collapsing non-primary TabBar on Material 3 #824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Turned off liftOnScroll because it [doesn't work with ViewPager](material-components/material-components-android#163). Could get it to work by dynamically setting the liftOnScrollTargetView - but not worth the difficulty for now. For liftOnScroll to work would need to support no_scroll flag on the Toolbar. Even if did that can't configure the colors for the lift on scroll programmatically so not worth the hassle. Best to turn it off for now to get the collapsing tabbar back
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a Material 3 theme to the Twitter sample stopped the collapsing TabBar on Notifications scene from working.
Turning off
liftOnScrollon the NavigationBar (AppBarLayout) gets it working again.Would be a lot of work to get liftOnScroll to work with the ViewPager. Not worth it until support turning off scroll on the Toolbar (
SCROLL_FLAG_NO_SCROLLflag) and even then Android Material doesn't allow programmatic setting ofliftOnScrollcolors.