Prevented primary TabBar flicker when changing tabs (Android) #827
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updating the Menu items caused flickering when changing tabs. Only updated if something has changed
The font size on the tab changes on old material theme when changing tab. So can't use an absolute font size otherwise text size jumps back to large after shrinking when tab deactivated. Switched to relative font size so that the custom font size is applied in proportion. Took 14 as the font size of tab when selected (checked by debugging RelativeSizeSpan) although can probably change via theming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the
MenuItemscaused flickering when changing tabs so avoided updating whenTabBarItemprops haven't changed. Also changed fromAbsolutetoRelativeSizeSpanso that font resizing is smooth when changing tabs on old Material theme.Thanks to @afkcodes for identifying and working through the problem.