Allowed detent change on bottom Sheet (Android) #833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes opening modal from non-first scene (see #832)
Fragment doesn't have an id. Was only throwing a soft exception on old react native so didn't notice. Latest react native throws a real exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #831
Provided valid tag when fetching event dispatcher. Used the View id instead of the empty Fragment id.
React Native used to throw a soft exception so didn't notice the problem. Latest React Native throws a hard exception.
Also updated Medley sample to latest navigation-react-native to support opening Sheet on all scenes.