7.0.x simplify #274
Merged
7.0.x simplify #274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesfredley
approved these changes
Dec 20, 2024
matrei
reviewed
Dec 20, 2024
| repositories { | ||
| if (useMavenLocal || useMavenLocal != 'last') { |
There was a problem hiding this comment.
@codeconsole Coming back to this ☝️ :
- If no
mavenLocalproperty is set, (useMavenLocal = null), I think this will addmavenLocal()as the first repository, asuseMavenLocalwill evaluate tofalsebutuseMavenLocal != 'last'will evaluate totrue. - If a
mavenLocalproperty is set to any value, (-PmavenLocal=last), I think this will also addmavenLocal()as the first repository asuseMavenLocalwill evaluate totrue.
Comment on lines
+41
to
+44
| if (useMavenLocal == 'last') { | ||
| println "Using mavenLocal() last on project `${prj.name}`" | ||
| mavenLocal() | ||
| } |
There was a problem hiding this comment.
I think it's better to set this before the Groovy Snapshot repo. Then it could be used for the Groovy Joint Workflow, if we want to do this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Eliminates need to modify after checkout.
or