Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Run release actions on ubuntu-22.04 #99

Merged
merged 3 commits into from
Mar 2, 2025
Merged

Conversation

ospencer
Copy link
Member

No description provided.

@ospencer ospencer requested a review from phated February 17, 2025 22:06
@ospencer ospencer self-assigned this Feb 17, 2025
Copy link
Member

@phated phated left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How are you planning to publish the opam release of the version you already tagged? Are you just publishing from your local?

@ospencer
Copy link
Member Author

I was planning to modify the actions file to run just the opam publish on this branch and push that commit so it runs in CI still. I suppose I can do that now before we merge this.

@phated
Copy link
Member

phated commented Feb 19, 2025

Yeah, let's get a working release before we merge this

@ospencer
Copy link
Member Author

@phated
Copy link
Member

phated commented Feb 23, 2025

Looks like it failed on their CI

@ospencer
Copy link
Member Author

That is indeed an issue that I'm looking at (looks like some type of cmake headache) but I don't think that blocks this PR.

@ospencer
Copy link
Member Author

The release has been merged.

@phated phated merged commit f549e14 into main Mar 2, 2025
27 checks passed
@phated phated deleted the oscar/release-pins branch March 2, 2025 03:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants