Move from toml library to tomli + tomli-w
#106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkow
previously approved these changes
Nov 26, 2022
There was a problem hiding this comment.
Reviewed 8 of 8 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dimakuv)
Suggestion:
`toml` library to `tomli` + `tomli-w`
`toml` Python library (for parsing and generating TOML files) is buggy and doesn't support the full spec of TOML 1.0.0. This commit replaces it with more robust `tomli` (for parsing) and `tomli-w` (for generating). Note that GSC supports both newer versions of Gramine (that also use `tomli`) and older versions of Gramine (that use `toml`). Signed-off-by: Dmitrii Kuvaiskii <[email protected]>
dimakuv
force-pushed
the
dimakuv/python-tomli
branch
from
9d6672b to
dbc17b6
Compare
dimakuv
commented
Nov 27, 2022
There was a problem hiding this comment.
Reviewable status: all files reviewed, 1 unresolved discussion, not enough approvals from maintainers (1 more required), not enough approvals from different teams (1 more required, approved so far: Intel) (waiting on @mkow)
-- commits line 2 at r1:
Done. Also changed dumping -> generating, similar to other PR (in core Gramine)
mkow
approved these changes
Nov 27, 2022
There was a problem hiding this comment.
Reviewed all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the changes
tomlPython library (for parsing and dumping TOML files) is buggy and doesn't support the full spec of TOML 1.0.0. This commit replaces it with more robusttomli(for parsing) andtomli-w(for dumping).Note that GSC supports both newer versions of Gramine (that also use
tomli) and older versions of Gramine (that usetoml).This PR is a counterpart to gramineproject/gramine#995, but is independent from it: GSC can work with new and old Gramine anyway.
How to test this PR?
Try e.g. Python example. Both
Branch: "v1.3.1"andBranch: "dimakuv/python-tomli"(from gramineproject/gramine#995) inconfig.yamlshould work.This change is