Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow Node users to leverage std/http and oak adapters #328

Merged
merged 1 commit into from
Dec 10, 2022

Conversation

KnorpelSenf
Copy link
Member

oak has Node builds.

As Node slowly starts taking in the same standards that Deno supports, it makes sense to allow Node users to adapter the API from Deno's standard library.

@codecov-commenter
Copy link

Codecov Report

Base: 36.88% // Head: 36.86% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (c4d7f9f) compared to base (ff9399f).
Patch coverage: 4.44% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #328      +/-   ##
==========================================
- Coverage   36.88%   36.86%   -0.02%     
==========================================
  Files          17       17              
  Lines        4360     4359       -1     
  Branches      157      157              
==========================================
- Hits         1608     1607       -1     
  Misses       2750     2750              
  Partials        2        2              
Impacted Files Coverage Δ
src/convenience/frameworks.deno.ts 35.71% <ø> (+18.14%) ⬆️
src/convenience/frameworks.shared.ts 10.22% <4.44%> (-6.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@KnorpelSenf KnorpelSenf merged commit b575f5d into main Dec 10, 2022
@KnorpelSenf KnorpelSenf deleted the share-stdhttp-oak branch December 10, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants