Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not JSON.stringify twice for serveHttp adapter #357

Merged
merged 2 commits into from
Jan 16, 2023
Merged

fix: do not JSON.stringify twice for serveHttp adapter #357

merged 2 commits into from
Jan 16, 2023

Conversation

KnorpelSenf
Copy link
Member

We already receive a JSON string, passing it to JSON.stringify seems wrong. I need someone to confirm this, though.

@KnorpelSenf KnorpelSenf requested a review from rojvv January 16, 2023 16:20
rojvv
rojvv approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@rojvv rojvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

src/convenience/frameworks.deno.ts Outdated Show resolved Hide resolved
src/convenience/frameworks.deno.ts Outdated Show resolved Hide resolved
@KnorpelSenf KnorpelSenf merged commit 275a17a into main Jan 16, 2023
@KnorpelSenf KnorpelSenf deleted the no-double-encode branch January 16, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rojvv rojvv rojvv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Coding
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KnorpelSenf @rojvv