Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: share resp generation code between framework adapters #378

Merged
merged 1 commit into from
Mar 9, 2023

Conversation

KnorpelSenf
Copy link
Member

This is possible since #376.

@codecov-commenter
Copy link

Codecov Report

Patch coverage: 5.26% and project coverage change: +0.31 🎉

Comparison is base (283a72b) 35.54% compared to head (b7c49e0) 35.85%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #378      +/-   ##
==========================================
+ Coverage   35.54%   35.85%   +0.31%     
==========================================
  Files          16       16              
  Lines        4727     4686      -41     
  Branches      166      166              
==========================================
  Hits         1680     1680              
+ Misses       3045     3004      -41     
  Partials        2        2              
Impacted Files Coverage Δ
src/convenience/frameworks.ts 8.07% <5.26%> (+1.10%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@dcdunkan dcdunkan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KnorpelSenf KnorpelSenf changed the title refactor: share response generatation code between framework adapters refactor: share resp generation code between framework adapters Mar 9, 2023
@KnorpelSenf KnorpelSenf merged commit 9f646bf into main Mar 9, 2023
@KnorpelSenf KnorpelSenf deleted the dry-adapters branch March 9, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants