-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for Bot API 6.6 #381
Conversation
Main thing to review are the newly introduced method signatures on the |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## main #381 +/- ##
==========================================
- Coverage 35.85% 35.16% -0.70%
==========================================
Files 16 16
Lines 4686 4778 +92
Branches 166 166
==========================================
Hits 1680 1680
- Misses 3004 3096 +92
Partials 2 2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
nice |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The second parameters of the methods setCustomEmojiStickerSetThumbnail
and setStickerMaskPosition
are marked optional in Telegram docs, while they are required here.
They are required because if one wants to remove the thumbnail (use the first), then which code do you find more readable? await ctx.api.setCustomEmojiStickerSetThumbnail(name) or await ctx.api.setCustomEmojiStickerSetThumbnail(name, "") ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. All the new signatures are correct.
https://core.telegram.org/bots/api#march-9-2023