Optionally ignore lock file #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gramps uses a lock file to ensure only one instance accesses a database at a time. So far, Web API respects this lock file, which makes sense e.g. when accessing the same database simultaneously with Web API and desktop. However, on a separate web server with multi-user access, this does not make sense as it can lead to errors when two requests happen simultaneously. Note that not respecting the lock file does not lead to inconsistencies - all database operations are still wrapped in transactions.
To preserve backwards compatibility, this PR adds the option to ignore the lock file through a configuration parameter, the default being the existing behaviour. The recommended setting will be to enable this on a web server where a desktop instance will not be used to access the database.