add (limited) images to relship chart #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me rebase & force-push due to the changes to translation file handling in main... |
DavidMStraub
force-pushed
the
relationship_graph_images
branch
from
894a6a2 to
625856c
Compare
|
Works great! The only problem I noticed is that long names overflow
but we can use ellipses like for the other charts
|
|
Should be fixed now |
DavidMStraub
added a commit
to DavidMStraub/Gramps.js
that referenced
this pull request
Jul 1, 2024
* add (limited) imaged to relship chart * Prevent names from overflowing in presence of images --------- Co-authored-by: David Straub <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#450 limit is set to 50