Remove unused settings (Log404Errors)

grandnode · Dec 27, 2023 · bb40668 · bb40668
1 parent 67a9840
commit bb40668
Show file tree

Hide file tree

Showing 6 changed files with 1 addition and 31 deletions.
diff --git a/src/Business/Grand.Business.System/Services/Installation/InstallDataSettings.cs b/src/Business/Grand.Business.System/Services/Installation/InstallDataSettings.cs
@@ -58,7 +58,6 @@ await _settingService.SaveSetting(new CommonSettings {
                 SitemapIncludeCategories = true,
                 SitemapIncludeBrands = true,
                 SitemapIncludeProducts = false,
-                Log404Errors = true,
                 PopupForTermsOfServiceLinks = true,
                 AllowToSelectStore = false
             });

diff --git a/src/Core/Grand.Domain/Common/CommonSettings.cs b/src/Core/Grand.Domain/Common/CommonSettings.cs
@@ -24,11 +24,6 @@ public CommonSettings()
         /// </summary>
         public List<string> SitemapCustomUrls { get; set; }
 
-        /// <summary>
-        /// Gets or sets a value indicating whether 404 errors (page or file not found) should be logged
-        /// </summary>
-        public bool Log404Errors { get; set; }
-
         /// <summary>
         /// Gets or sets a ignore words (phrases) to be ignored when logging errors/messages
         /// </summary>

diff --git a/...Admin/Areas/Admin/Views/Setting/Partials/GeneralCommon.TabStoreInformationSettings.cshtml b/...Admin/Areas/Admin/Views/Setting/Partials/GeneralCommon.TabStoreInformationSettings.cshtml
@@ -296,19 +296,7 @@
                 <span asp-validation-for="CommonSettings.PopupForTermsOfServiceLinks"></span>
             </div>
         </div>
-        <div class="form-group">
-            <div class="col-8 col-md-4 col-sm-4 text-right">
-                <admin-label asp-for="CommonSettings.Log404Errors" class="control-label" />
-            </div>
-            <div class="col-4 col-md-8 col-sm-8">
-                <label class="mt-checkbox mt-checkbox-outline control control-checkbox">
-                    <admin-input asp-for="CommonSettings.Log404Errors" />
-                    <div class="control__indicator"></div>
-                </label>
-                <span asp-validation-for="CommonSettings.Log404Errors"></span>
-            </div>
-        </div>
-        <div class="form-group">
+    <div class="form-group">
             <div class="col-8 col-md-4 col-sm-4 text-right">
                 <admin-label asp-for="CommonSettings.SitemapEnabled" class="control-label" />
             </div>

diff --git a/src/Web/Grand.Web.Admin/Models/Settings/GeneralCommonSettingsModel.cs b/src/Web/Grand.Web.Admin/Models/Settings/GeneralCommonSettingsModel.cs
@@ -116,9 +116,6 @@ public class CommonSettingsModel : BaseModel
             [GrandResourceDisplayName("Admin.Settings.GeneralCommon.AllowToSelectStore")]
             public bool AllowToSelectStore { get; set; }
 
-            [GrandResourceDisplayName("Admin.Settings.GeneralCommon.Log404Errors")]
-            public bool Log404Errors { get; set; }
-
             [GrandResourceDisplayName("Admin.Settings.GeneralCommon.PopupForTermsOfServiceLinks")]
             public bool PopupForTermsOfServiceLinks { get; set; }
 

diff --git a/src/Web/Grand.Web.Common/Infrastructure/ApplicationBuilderExtensions.cs b/src/Web/Grand.Web.Common/Infrastructure/ApplicationBuilderExtensions.cs
@@ -105,12 +105,6 @@ public static void UsePageNotFound(this IApplicationBuilder application)
                         const string location = "/page-not-found";
                         context.HttpContext.Response.Redirect(context.HttpContext.Request.PathBase + location);
                     }
-                    var commonSettings = context.HttpContext.RequestServices.GetRequiredService<CommonSettings>();
-                    if (commonSettings.Log404Errors)
-                    {
-                        var logger = context.HttpContext.RequestServices.GetRequiredService<ILoggerFactory>().CreateLogger("UseStatusCodePages");
-                        logger.LogError("Error 404. The requested page ({DisplayUrl}) was not found", context.HttpContext.Request.GetDisplayUrl());
-                    }
                 }
                 await Task.CompletedTask;
             });

diff --git a/src/Web/Grand.Web/App_Data/Resources/DefaultLanguage.xml b/src/Web/Grand.Web/App_Data/Resources/DefaultLanguage.xml
@@ -10266,9 +10266,6 @@
 	<Resource Name="Admin.Settings.GeneralCommon.LinkedInLink" Area="Admin">
 		<Value>LinkedIn page URL</Value>
 	</Resource>
-	<Resource Name="Admin.Settings.GeneralCommon.Log404Errors" Area="Admin">
-		<Value>Log 404 errors</Value>
-	</Resource>
 	<Resource Name="Admin.Settings.GeneralCommon.Logo" Area="Admin">
 		<Value>Logo</Value>
 	</Resource>