Get rid of executeV2
, just replace execute
#1980
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a breaking change; it turns out that having both
execute
andexecuteV2
is super annoying, and the defaultexecuteV2
function that aimed to give backwards compatibility withexecute
was even broken... Not ideal. Rather than explaining to everyone that we have two methods, I've decided to just replaceexecute
withexecuteV2
entirely. Anyone who has written a custom step class with anexecute
method will need to update it; but doing so is straightforward - you just need to destructure the argument and add a line of code to the top of the function that converts the newvalues
tuple to be in the same format as the legacyvalues
tuple:Performance impact
An improvement that is unlikely to be measurable.
Security impact
Less surface area: better security.
Checklist
yarn lint:fix
passes.I've added tests for the new feature, andyarn test
passes.RELEASE_NOTES.md
file (if one exists).