Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use cache in subscription or mutation mode #2146

Merged
merged 3 commits into from
Aug 6, 2024
Merged

Conversation

benjie
Copy link
Member

@benjie benjie commented Aug 6, 2024

Description

Fixes #2079; verified by making the mod manually in node_modules of a reproduction.

Performance impact

Marginal.

Security impact

None known.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented Aug 6, 2024

🦋 Changeset detected

Latest commit: f4ee239

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@dataplan/pg Patch
graphile-build-pg Patch
graphile-utils Patch
pgl Patch
postgraphile Patch
graphile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie merged commit f762ee3 into main Aug 6, 2024
36 checks passed
@benjie benjie deleted the fix-pgexecutor-caching branch August 6, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

PgExecutor cache is not cleared between subscription payloads
1 participant