Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable stabilization of objects/lists going through loadMany/loadOne multistep #2193

Merged
merged 8 commits into from
Oct 2, 2024

Conversation

benjie
Copy link
Member

@benjie benjie commented Oct 2, 2024

Description

Fixes #2170

Performance impact

Marginal performance cost for loadOne/loadMany calls that accept object/list specs.

Security impact

Generally an improvement I hope, though there's a risk of memory exhaustion attacks if this is not used sensibly.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented Oct 2, 2024

🦋 Changeset detected

Latest commit: b77f6e9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 15 packages
Name Type
@dataplan/pg Patch
grafast Patch
graphile-build-pg Patch
graphile-utils Patch
pgl Patch
postgraphile Patch
@localrepo/grafast-bench Patch
@dataplan/json Patch
@grafserv/persisted Patch
grafserv Patch
ruru-components Patch
@localrepo/grafast-website Patch
graphile-build Patch
graphile-export Patch
graphile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie merged commit 8c0a370 into main Oct 2, 2024
36 checks passed
@benjie benjie deleted the stable-multistep branch October 2, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

RFC: stable object step
1 participant