Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checks for "from" field in pgSelect dedup function #2258

Merged
merged 7 commits into from
Dec 2, 2024

Conversation

kzlar
Copy link
Contributor

@kzlar kzlar commented Nov 29, 2024

Description

https://discord.com/channels/489127045289476126/498852330754801666/1312193983308365865
I think I found a potential edge case, wondering your thoughts on it. I have two plans implemented in makeExtendedScemaPlugin, both are implemented manually with calling pgSelect with a custom from function. I'm calling both of them in a query and I think they're getting deduplicated, even though from implementation is different.

Performance impact

unknown. Theoretically it would deduplicate less than before, but I think that any such deduplications would have been erroneous.

Security impact

unknown, but don't expect it to change anything.

Checklist

  • My code matches the project's code style and yarn lint:fix passes.
  • I've added tests for the new feature, and yarn test passes.
  • I have detailed the new feature in the relevant documentation.
  • I have added this feature to 'Pending' in the RELEASE_NOTES.md file (if one exists).
  • If this is a breaking change I've explained why.

Copy link

changeset-bot bot commented Nov 29, 2024

🦋 Changeset detected

Latest commit: cba6ee0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@dataplan/pg Patch
ruru-components Patch
graphile-utils Patch
graphile-build-pg Patch
pgl Patch
postgraphile Patch
graphile Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@benjie benjie mentioned this pull request Dec 2, 2024
@benjie benjie force-pushed the bug/pgselect-dedup-check-from branch from 58bb26a to 427b16c Compare December 2, 2024 10:40
@benjie benjie marked this pull request as ready for review December 2, 2024 12:05
benjie
benjie previously approved these changes Dec 2, 2024
@benjie benjie merged commit 72f8774 into graphile:main Dec 2, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants