Added checks for "from" field in pgSelect dedup function #2258
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://discord.com/channels/489127045289476126/498852330754801666/1312193983308365865
I think I found a potential edge case, wondering your thoughts on it. I have two plans implemented in makeExtendedScemaPlugin, both are implemented manually with calling pgSelect with a custom from function. I'm calling both of them in a query and I think they're getting deduplicated, even though from implementation is different.
Performance impact
unknown. Theoretically it would deduplicate less than before, but I think that any such deduplications would have been erroneous.
Security impact
unknown, but don't expect it to change anything.
Checklist
yarn lint:fix
passes.yarn test
passes.RELEASE_NOTES.md
file (if one exists).