-
-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initital Hono grafserv adapter #2297
base: main
Are you sure you want to change the base?
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to see work being done on this! Suggest that you find other people using hono to validate the approach - feel free to ask around in #watercooler on the Discord.
honov4: { | ||
ctx: ctx, | ||
}, | ||
node: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the purpose of this node
object? I had to remove it when running the adapter on Node 22 and 23, ti works on Node 20 however. Also typescript warns that it should not be there.
Also otherwise I would get obscure and unrelated error (TypeError: Cannot read properties of undefined (reading 'reloadNavigation')
Description
This PR adds a initial Hono adapter to grafserv. I won't handle bufferStream or websockets yet.
Performance impact
n/a
Security impact
unknown
Checklist
yarn lint:fix
passes.yarn test
passes.RELEASE_NOTES.md
file (if one exists).