Add random number to notify payload to prevent deduplication

graphile · Nov 14, 2023 · 07f62be · 07f62be
1 parent 50752a2
commit 07f62be
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/__tests__/schema.sql b/__tests__/schema.sql
@@ -106,7 +106,7 @@ begin
       returning *
       into v_job;
     if v_job.revision = 0 then
-      perform pg_notify('jobs:insert', '{"count":1}');
+      perform pg_notify('jobs:insert', '{"r":' || random()::text || ',"count":1}');
     end if;
     return v_job;
   else
@@ -144,7 +144,7 @@ begin
   and jobs.key = spec.job_key
   and is_available is not true;
   -- WARNING: this count is not 100% accurate; 'on conflict' clause will cause it to be an overestimate
-  perform pg_notify('jobs:insert', '{"count":' || array_length(specs, 1)::text || '}');
+  perform pg_notify('jobs:insert', '{"r":' || random()::text || ',"count":' || array_length(specs, 1)::text || '}');
   -- TODO: is there a risk that a conflict could occur depending on the
   -- isolation level?
   return query insert into "graphile_worker"._private_jobs as jobs (
@@ -254,7 +254,7 @@ begin
     )
   returning * into v_job;
   if not (v_job is null) then
-    perform pg_notify('jobs:insert', '{"count":-1}');
+    perform pg_notify('jobs:insert', '{"r":' || random()::text || ',"count":-1}');
     return v_job;
   end if;
   -- Otherwise prevent job from retrying, and clear the key

diff --git a/sql/000018.sql b/sql/000018.sql
@@ -76,7 +76,7 @@ begin
       returning *
       into v_job;
     if v_job.revision = 0 then
-      perform pg_notify('jobs:insert', '{"count":1}');
+      perform pg_notify('jobs:insert', '{"r":' || random()::text || ',"count":1}');
     end if;
     return v_job;
   else
@@ -116,7 +116,7 @@ begin
   and is_available is not true;
 
   -- WARNING: this count is not 100% accurate; 'on conflict' clause will cause it to be an overestimate
-  perform pg_notify('jobs:insert', '{"count":' || array_length(specs, 1)::text || '}');
+  perform pg_notify('jobs:insert', '{"r":' || random()::text || ',"count":' || array_length(specs, 1)::text || '}');
 
   -- TODO: is there a risk that a conflict could occur depending on the
   -- isolation level?
@@ -190,7 +190,7 @@ begin
     )
   returning * into v_job;
   if not (v_job is null) then
-    perform pg_notify('jobs:insert', '{"count":-1}');
+    perform pg_notify('jobs:insert', '{"r":' || random()::text || ',"count":-1}');
     return v_job;
   end if;
   -- Otherwise prevent job from retrying, and clear the key

diff --git a/src/generated/sql.ts b/src/generated/sql.ts