Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cleanup TAPCollectorAuthorizationAlreadyRevoked #1089

Closed
wants to merge 1 commit into from

Conversation

matiasedgeandnode
Copy link
Contributor

This PR simply cleans up what's already there, but if you would consider a slightly bigger re-write, maybe the collector would benefit from a modifier onlyAuthorized(address _signer) for thawSigner, cancelThawSigner and revokeAuthorizedSigner like what's proposed by #1085 -> here.

Copy link

fix: cleanup TAPCollectorAuthorizationAlreadyRevoked

Generated at commit: 80fa1b02bc5ddb0dd0ada53d41e79c580c232ccd

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
5
0
15
39
61
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@tmigone
Copy link
Contributor

tmigone commented Jan 16, 2025

I like what you did with Authorizable! Want to PR it into horizon?

@matiasedgeandnode
Copy link
Contributor Author

Please look at #1110 instead.

@matiasedgeandnode matiasedgeandnode deleted the ma/fix-tap-already-revoked branch February 13, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants