Allow batch transactions using multicall in the GNS #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davekaj
suggested changes
Jul 26, 2021
| @@ -983,4 +983,68 @@ describe('GNS', () => { | |||
| await gns.connect(me.signer).mintNSignal(me.address, 1, toGRT('10'), 0) | |||
| }) | |||
| }) | |||
|
|
|||
| describe('batch calls', function () { | |||
There was a problem hiding this comment.
looks good. i would like to add a few tests to play it safe. i want to add the following sequences:
- publishSubgraph, publishSubgraph
- publishSubgraph, publishNewVersion
- publishSubgraph, mintNSignal, burnNsignal
I think it will be fine. I can write the tests for these
abarmat
force-pushed
the
ariel/gns-multicall
branch
from
be047e6 to
94b8464
Compare
|
Rebased |
|
This is pretty cool @abarmat ! It will be easy to implement it on our end :-D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
By using a multicall a user can batch multiple operations into a single transaction.
An example of this is if the owner publishing a subgraph decides to mint some signal on that subgraph.