Use a minimal proxy for the curation shares ERC20 #505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #505 +/- ##
==========================================
+ Coverage 91.91% 91.95% +0.03%
==========================================
Files 33 33
Lines 1658 1666 +8
Branches 282 279 -3
==========================================
+ Hits 1524 1532 +8
Misses 134 134
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
abarmat
force-pushed
the
ariel/curation-token-minimal-proxy
branch
from
ff07ea6 to
40b1da3
Compare
|
Rebased |
abarmat
force-pushed
the
ariel/curation-token-minimal-proxy
branch
from
40b1da3 to
1a2a89b
Compare
|
Great job |
jona
pushed a commit
that referenced
this pull request
Dec 3, 2021
* curation: use a minimal proxy to save gas when minting for first time * curation: use token utils for transfers * tests: remove unnecessary block advance in test * curation: add external function to set token master copy and avoid re-deploy the clone on minting reset * chore: add graph curation master copy token to deployment config
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Signal on a subgraph deployment is represented by a subgraph-specific ERC20 token. When signal is minted for a subgraph deployment for the first time, the Curation contract deploys a new ERC20 token. This is costly, about 1.2M gas.
Solution
Use a Minimal Proxy to clone the Signal-ERC20 based on an implementation. First mint goes from 1,230,118 gas to 432,840