Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arbitrum devnet with rewards distribution #571

Merged
merged 44 commits into from
Jul 27, 2022

Conversation

pcarranzav
Copy link
Member

@pcarranzav pcarranzav commented May 17, 2022

This PR adds a full deployment to the Arbitrum One layer 2, and refactors rewards distribution so that they can be periodically dripped on L1. A fraction of the minted rewards can be sent to L2 (which would initially be 0 in the devnet phase).

Full GIP pending.

This PR temporarily targets the pcv/arb-bridge-cli branch as it depends on #552 and #556 being merged first. It also includes the changes from #569 as I'm assuming that will be merged and deployed before this.

@pcarranzav pcarranzav force-pushed the pcv/arb-full-deployment branch 2 times, most recently from c7e19da to 818d0c9 Compare May 18, 2022 19:24
@pcarranzav pcarranzav force-pushed the pcv/arb-full-deployment branch from 8fce39d to 574e962 Compare May 25, 2022 20:31
@pcarranzav pcarranzav force-pushed the pcv/arb-bridge-cli branch from 053ef34 to f5a5f24 Compare May 25, 2022 21:17
@pcarranzav pcarranzav force-pushed the pcv/arb-full-deployment branch 6 times, most recently from 0eb2fa1 to 4bc5da3 Compare May 31, 2022 13:55
@pcarranzav pcarranzav force-pushed the pcv/arb-bridge-cli branch from f5a5f24 to 87f4bec Compare May 31, 2022 14:03
@pcarranzav pcarranzav force-pushed the pcv/arb-full-deployment branch from 4bc5da3 to 6234aa0 Compare May 31, 2022 14:13
@pcarranzav pcarranzav force-pushed the pcv/arb-bridge-cli branch from 87f4bec to edbc3e0 Compare May 31, 2022 14:54
@pcarranzav pcarranzav force-pushed the pcv/arb-full-deployment branch from 6234aa0 to cf6f068 Compare May 31, 2022 14:55
@pcarranzav pcarranzav changed the title WIP: Arbitrum devnet with rewards distribution Arbitrum devnet with rewards distribution May 31, 2022
@pcarranzav
Copy link
Member Author

Marking this as ready for review, but it depends on #552 and #556 being merged first. I'll also be working on writing the GIP for this soon.
This has not been tested on a testnet yet, only with the unit tests provided in the PR.

@pcarranzav pcarranzav marked this pull request as ready for review May 31, 2022 15:48
@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #571 (8426b4c) into pcv/arb-bridge-cli (359d254) will increase coverage by 0.64%.
The diff coverage is 99.61%.

@@                  Coverage Diff                   @@
##           pcv/arb-bridge-cli     #571      +/-   ##
======================================================
+ Coverage               91.27%   91.92%   +0.64%     
======================================================
  Files                      40       44       +4     
  Lines                    1948     2080     +132     
  Branches                  321      356      +35     
======================================================
+ Hits                     1778     1912     +134     
+ Misses                    170      168       -2     
Flag Coverage Δ
unittests 91.92% <99.61%> (+0.64%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contracts/tests/ReservoirMock.sol 66.66% <66.66%> (ø)
contracts/gateway/BridgeEscrow.sol 100.00% <100.00%> (ø)
contracts/gateway/GraphTokenGateway.sol 100.00% <100.00%> (ø)
contracts/gateway/L1GraphTokenGateway.sol 100.00% <100.00%> (ø)
contracts/governance/Managed.sol 100.00% <100.00%> (+1.88%) ⬆️
contracts/l2/gateway/L2GraphTokenGateway.sol 100.00% <100.00%> (ø)
contracts/l2/reservoir/L2Reservoir.sol 100.00% <100.00%> (ø)
contracts/l2/token/GraphTokenUpgradeable.sol 100.00% <100.00%> (ø)
contracts/l2/token/L2GraphToken.sol 100.00% <100.00%> (ø)
contracts/reservoir/L1Reservoir.sol 100.00% <100.00%> (ø)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 359d254...8426b4c. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants