fix: ensure GRE handles multiple chains with same chainId gracefully #695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomás Migone <[email protected]>
Codecov Report
@@ Coverage Diff @@
## dev #695 +/- ##
=======================================
Coverage 90.35% 90.35%
=======================================
Files 35 35
Lines 1762 1762
Branches 296 296
=======================================
Hits 1592 1592
Misses 170 170
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Tomás Migone <[email protected]>
abarmat
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This PR fixes a bug in GRE where it would always connect to the first network in the case where multiple chains are listed in
hardhat.config.tswith the same chainId. This is most likely to happen with local networks colliding with hardhat's own network (chainId=1337).Changes
Now GRE will try to use the main network name (as specified by
--network) to disambiguate and if that is not enough it will throw an error saying this behavior is not supported.Signed-off-by: Tomás Migone [email protected]