[Experimental] Arbitrum bridge + rewards distribution: alternative approach #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deployment commands in the CLI are also updated to include an L2 deployment. Configuration and address book entries for Arbitrum are added as well.
We also add Goerli and Arbitrum Nitro Devnet configurations (though the CLI commands don't support Nitro yet).
BREAKING CHANGE: remove setIssuanceRate from RewardsManager interface BREAKING CHANGE: RewardsDenied event now includes amount
…ear they're decoupled [L-03]
… confusion [L-10]
…-merge-552-fixes This includes all the audit fixes on PR #552.
… L2 [H-03] [L-03]
…in L2 and without reservoirs
Codecov Report
@@ Coverage Diff @@
## dev #697 +/- ##
==========================================
+ Coverage 90.35% 91.43% +1.08%
==========================================
Files 35 41 +6
Lines 1762 1974 +212
Branches 296 344 +48
==========================================
+ Hits 1592 1805 +213
+ Misses 170 169 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
Replaced by #700 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying a different approach to the one from GIP-0034: Minting on L2 and not using a reservoir drip. For now just making the changes to compare and make sure we're choosing the best solution. WIP.