Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run GitHub actions only when it makes sense #707

Merged
merged 1 commit into from
Sep 29, 2022
Merged

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Sep 6, 2022

Don't run GitHub actions when it's not necessary!

@tmigone tmigone marked this pull request as draft September 6, 2022 14:58
@codecov
Copy link

codecov bot commented Sep 6, 2022

Codecov Report

Base: 90.57% // Head: 90.57% // No change to project coverage 👍

Coverage data is based on head (2f5fcad) compared to base (0ca43ff).
Patch has no changes to coverable lines.

❗ Current head 2f5fcad differs from pull request most recent head 036bb2e. Consider uploading reports for the commit 036bb2e to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #707   +/-   ##
=======================================
  Coverage   90.57%   90.57%           
=======================================
  Files          35       35           
  Lines        1762     1762           
  Branches      296      296           
=======================================
  Hits         1596     1596           
  Misses        166      166           
Flag Coverage Δ
unittests 90.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@tmigone tmigone force-pushed the tmigone/gh-path-filter branch from 657bd2c to b5570e1 Compare September 28, 2022 21:52
@tmigone tmigone marked this pull request as ready for review September 28, 2022 21:52
pcarranzav
pcarranzav previously approved these changes Sep 28, 2022
Copy link
Member

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one comment

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@tmigone tmigone force-pushed the tmigone/gh-path-filter branch from 2f5fcad to 036bb2e Compare September 28, 2022 22:37
@tmigone tmigone requested a review from pcarranzav September 28, 2022 22:38
@tmigone tmigone merged commit b6219d3 into dev Sep 29, 2022
@tmigone tmigone deleted the tmigone/gh-path-filter branch September 29, 2022 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants