Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update some contracts to use solidity 0.8 #725

Closed
wants to merge 8 commits into from

Conversation

pcarranzav
Copy link
Member

experimental / WIP, take this with a bucketful of salt, might not work, etc

@socket-security
Copy link

socket-security bot commented Sep 29, 2022

Socket Security Report

Dependency issues detected. If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 New install scripts detected

A dependency change in this PR is introducing new install scripts to your install step.

Package Script field Location
[email protected] (added) binding.gyp package.json via @nomicfoundation/[email protected], [email protected]
[email protected] (added) install package.json via @nomicfoundation/[email protected], [email protected]
[email protected] (upgraded) postinstall package.json
🫣 Native code

Contains native code which could be a vector to obscure malicious code, and generally decrease the likelihood of reproducible or reliable installs.

Package Location
[email protected] (added) package.json via @nomicfoundation/[email protected], [email protected]
😵‍💫 Bin script confusion

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack.

Package Bin script Location
@nomicfoundation/[email protected] (added) rlp package.json
[email protected] (added) rlp package.json via [email protected], @ethereum-waffle/[email protected], [email protected], [email protected]
[email protected] (added) rlp package.json
Socket.dev scan summary
Issue Status
Did you mean? ✅ no new possible package typos
Install scripts ⚠️ 3 new install scripts detected
Telemetry ✅ no new telemetry
Troll package ✅ no new troll packages
Malware ✅ no new malware
Native code ⚠️ 1 new native module detected
Bin Script Confusion ⚠️ 3 new bin script confusions detected
Bin script shell injection ✅ no new bin script shell injection
Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore [email protected] [email protected]

Powered by socket.dev

@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Base: 91.56% // Head: 91.54% // Decreases project coverage by -0.02% ⚠️

Coverage data is based on head (fc7120d) compared to base (263355d).
Patch coverage: 88.97% of modified lines in pull request are covered.

Additional details and impacted files
@@                    Coverage Diff                    @@
##           pcv/l2-linear-rewards     #725      +/-   ##
=========================================================
- Coverage                  91.56%   91.54%   -0.03%     
=========================================================
  Files                         42       42              
  Lines                       2003     1998       -5     
  Branches                     350      350              
=========================================================
- Hits                        1834     1829       -5     
  Misses                       169      169              
Flag Coverage Δ
unittests 91.54% <88.97%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contracts/base/Multicall.sol 100.00% <ø> (ø)
contracts/curation/GraphCurationToken.sol 100.00% <ø> (ø)
contracts/discovery/ServiceRegistry.sol 100.00% <ø> (ø)
contracts/discovery/SubgraphNFTDescriptor.sol 100.00% <ø> (ø)
...ontracts/discovery/erc1056/EthereumDIDRegistry.sol 0.00% <ø> (ø)
contracts/gateway/BridgeEscrow.sol 100.00% <ø> (ø)
contracts/gateway/GraphTokenGateway.sol 100.00% <ø> (ø)
contracts/governance/Controller.sol 100.00% <ø> (ø)
contracts/governance/Governed.sol 100.00% <ø> (ø)
contracts/governance/GraphGovernance.sol 100.00% <ø> (ø)
... and 32 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pcarranzav pcarranzav closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant