Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: provide sane defaults for graph config (l2-bridge branch) re-#722 #727

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Oct 3, 2022

#722 was reverted due to the upcoming audit/contest. We should merge this after they are over.

@codecov
Copy link

codecov bot commented Oct 3, 2022

Codecov Report

Base: 91.51% // Head: 91.69% // Increases project coverage by +0.18% 🎉

Coverage data is based on head (ba021fd) compared to base (105b4f0).
Patch has no changes to coverable lines.

Additional details and impacted files
@@                Coverage Diff                @@
##           pcv/l2-bridge     #727      +/-   ##
=================================================
+ Coverage          91.51%   91.69%   +0.18%     
=================================================
  Files                 41       42       +1     
  Lines               1980     2024      +44     
  Branches             346      360      +14     
=================================================
+ Hits                1812     1856      +44     
  Misses               168      168              
Flag Coverage Δ
unittests 91.69% <ø> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contracts/l2/gateway/L2GraphTokenGateway.sol 100.00% <0.00%> (ø)
contracts/tests/CallhookReceiverMock.sol 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tmigone tmigone requested review from pcarranzav and abarmat and removed request for pcarranzav October 4, 2022 20:10
@tmigone tmigone merged commit 08cddfa into pcv/l2-bridge Oct 4, 2022
@tmigone tmigone deleted the tmigone/gre-defaults-l2 branch October 4, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants