Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: print gas report, and ensure evm is killed #732

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

pcarranzav
Copy link
Member

  • Gas report is saved to reports/ folder, but usually we want to see it in the console, so here we add a cat command to print it
  • The EVM wasn't being killed properly if the tests failed, so here we add a trap to ensure the cleanup happens

@pcarranzav pcarranzav requested review from abarmat and tmigone October 13, 2022 18:05
@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 90.57% // Head: 90.57% // No change to project coverage 👍

Coverage data is based on head (0b7055a) compared to base (f1c5fe7).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #732   +/-   ##
=======================================
  Coverage   90.57%   90.57%           
=======================================
  Files          35       35           
  Lines        1762     1762           
  Branches      296      296           
=======================================
  Hits         1596     1596           
  Misses        166      166           
Flag Coverage Δ
unittests 90.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pcarranzav pcarranzav merged commit 3f16e5a into dev Oct 14, 2022
@pcarranzav pcarranzav deleted the pcv/test-gas-cat-report branch October 14, 2022 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants