Code

c4: gas optimization fixes#742

Code

Merged

pcarranzav merged 17 commits intopcv/l2-bridgegraphprotocol/contracts:pcv/l2-bridgefrom tmigone/c4-gasgraphprotocol/contracts:tmigone/c4-gasCopy head branch name to clipboardNov 23, 2022

+95-92

Commits

Commits on Oct 24, 2022

• fix(c4-117-g03): state variables should be cached in stack variables

  Show description for 2c4ac9d
  tmigone

  committed
  2c4ac9d

  Copy full SHA for 2c4ac9d

• fix(c4-117-g05): require()/revert() strings longer than 32 bytes cost extra gas

  Show description for 76865a4
  tmigone

  committed
  76865a4

  Copy full SHA for 76865a4

• fix(c4-117-g06): keccak256() should only need to be called on a specific string literal once

  Show description for 18afb3a
  tmigone

  committed
  18afb3a

  Copy full SHA for 18afb3a

• fix(c4-117-g11): using > 0 costs more gas than != 0 when used on a uint in a require()

  Show description for ee5d3cb
  tmigone

  committed
  ee5d3cb

  Copy full SHA for ee5d3cb

• fix(c4-117-g12): splitting require() statements that use && saves gas

  Show description for 71314dd
  tmigone

  committed
  71314dd

  Copy full SHA for 71314dd

• fix(c4-117-g15): require() or revert() statements that check input arguments should be at the

  Show description for d5aece4
  tmigone

  committed
  d5aece4

  Copy full SHA for d5aece4

• fix(c4-6-g07): expressions for constant values such as a call to keccak256(), should use 

  Show description for 2ad9f4e
  tmigone

  committed
  2ad9f4e

  Copy full SHA for 2ad9f4e

• fix(c4-6-g08): duplicated require()/revert() checks should be refactored to a modifier or

  Show description for e0440a8
  tmigone

  committed
  e0440a8

  Copy full SHA for e0440a8

• fix(c4-6-13): use calldata instead of memory for function parameters

  Show description for 3805ca9
  tmigone

  committed
  3805ca9

  Copy full SHA for 3805ca9

• fix(c4-86-g07): emitting or returning storage values

  Show description for 54157a7
  tmigone

  committed
  54157a7

  Copy full SHA for 54157a7

Commits on Oct 27, 2022

• fix(c4-172-g02): set allowance to 0 instead of decreasing allowance by approved amount

  Show description for 7d29d6d
  tmigone

  committed
  7d29d6d

  Copy full SHA for 7d29d6d

• fix(c4-287-g01): remove unused local variable

  Show description for 534d224
  tmigone

  committed
  534d224

  Copy full SHA for 534d224

• fix(c4-272): remove unnecessary use of safe math

  Show description for 0b7ad55
  tmigone

  committed
  0b7ad55

  Copy full SHA for 0b7ad55

• fix(c4-272): remove unnecessary usage of safemath

  Show description for d091781
  tmigone

  committed
  d091781

  Copy full SHA for d091781

• fix: further optimize governed contract

  Show description for 1f85e12
  tmigone

  committed
  1f85e12

  Copy full SHA for 1f85e12

• fix: add visibility to managed immutable vars

  Show description for 27902cc
  tmigone

  committed
  27902cc

  Copy full SHA for 27902cc

• fix: update e2e tests to new error messages

  Show description for e3a668e
  tmigone

  committed
  e3a668e

  Copy full SHA for e3a668e