Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(L1GraphTokenGateway): add a counterpartGateway getter for Router compatibility #748

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

pcarranzav
Copy link
Member

No description provided.

Copy link
Contributor

@abarmat abarmat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@pcarranzav pcarranzav force-pushed the pcv/add-counterpart-gateway-fn branch from 4196e39 to d8fed24 Compare November 14, 2022 13:34
@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Base: 91.58% // Head: 91.59% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (d8fed24) compared to base (caf5ab5).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                      Coverage Diff                      @@
##           pcv/fix-bridge-callhook-data     #748   +/-   ##
=============================================================
  Coverage                         91.58%   91.59%           
=============================================================
  Files                                42       42           
  Lines                              1997     1999    +2     
  Branches                            361      361           
=============================================================
+ Hits                               1829     1831    +2     
  Misses                              168      168           
Flag Coverage Δ
unittests 91.59% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
contracts/gateway/L1GraphTokenGateway.sol 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Base automatically changed from pcv/fix-bridge-callhook-data to pcv/l2-bridge November 23, 2022 14:38
@pcarranzav
Copy link
Member Author

I'll go ahead and merge, note this didn't make it into the latest audits but is a safe change as it only adds a getter (view) function.

@pcarranzav pcarranzav merged commit d8fed24 into pcv/l2-bridge Nov 23, 2022
@pcarranzav pcarranzav deleted the pcv/add-counterpart-gateway-fn branch November 23, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants