Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: integrate bridge tasks with arbitrum sdk #760

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

tmigone
Copy link
Contributor

@tmigone tmigone commented Dec 5, 2022

Changes

  • Integrate Arbitrum SDK on bridge:deposits and bridge:withdrawals tasks to show message status
  • Rework how tables are shown a bit.

Signed-off-by: Tomás Migone [email protected]

@tmigone tmigone requested a review from pcarranzav December 5, 2022 16:24
@tmigone
Copy link
Contributor Author

tmigone commented Dec 5, 2022

Screen Shot 2022-12-05 at 13 21 40

@tmigone tmigone requested a review from abarmat December 5, 2022 16:26
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Base: 91.59% // Head: 91.59% // No change to project coverage 👍

Coverage data is based on head (9e6cfbb) compared to base (47e5f15).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #760   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files          42       42           
  Lines        1999     1999           
  Branches      361      361           
=======================================
  Hits         1831     1831           
  Misses        168      168           
Flag Coverage Δ
unittests 91.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@pcarranzav pcarranzav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

tasks/bridge/deposits.ts Show resolved Hide resolved
@tmigone tmigone merged commit fd7032b into dev Dec 6, 2022
@tmigone tmigone deleted the tmigone/bridge-tasks-improvements branch December 6, 2022 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants